Removes delay when failing to move #6498
Conversation
|
how does this affect bodyblocking? |
Needs to be TMed to find out |
|
From some wacky testing it looks like it makes it impossible to bodyblock mobs that a bigger than you (mobs that you can't push) |
|
Actually it is probably a bad thing since it allows you to push things at full speed |
|
I am not inclined this should change. Nor does it eliminate the possibility of inputs being dropped in the situation its explicitly trying to improve. Waiting on other maintainer feedback before just closing however. |
|
In a similar question to body blocking, does this rapidly speed-up the rate at which non-anchored objects are pushed? This could inadvertently be much more powerful for xenos. If I had a suggestion, it might be be more appropriate to only remove the delay if the user pushes against a non-anchored object. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
About the pull request
Remove the delay when you fail to move (aka move into a dense object)
(there is still a minimal delay to reduce spam on code)
Explain why it's good for the game
Makes moving a lot smoother, currently it just feels like your clicks are getting eaten which gets worse with lower movement speeds and higher ping (what is happening is you get full move delay if you move into a dense object so if you mistime it looks like your clicks get eaten)
Testing Photographs and Procedure
Both videos are me holding the W key and pressing the D key rapidly
Current:
2024-06-17.21-15-03.mp4
After the PR:
2024-06-17.21-17-19.mp4
Changelog
🆑
qol: Removed delay when failing to move
fix: You longer take damage from shrapnel when failing to move
/:cl: